Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wysiwyg textarea width when window zoom !== 100% #7848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zsviczian
Copy link
Collaborator

@zsviczian zsviczian commented Apr 3, 2024

fixes: #7847

Here's my test container: https://excalidraw-6pc2v020f-excalidraw.vercel.app/#json=aZ4Unb4qtOAVvp-rvjsY-,sj2COn1LEP7E9F0ozvf49Q

If you copy/paste this into excalidraw.com production and change browser zoom to 110% the text jumps on edit.

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Apr 3, 2024 8:43pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Apr 3, 2024 8:43pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Apr 3, 2024 8:43pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 3, 2024 8:43pm

Copy link

github-actions bot commented Apr 3, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 64.35% (🎯 70%) 47460 / 73744
🔴 Statements 64.35% (🎯 70%) 47460 / 73744
🔴 Functions 65.26% (🎯 68%) 1411 / 2162
🟢 Branches 79.89% (🎯 70%) 5684 / 7114
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/element/textWysiwyg.tsx 84.71% 79.34% 81.25% 84.71% 63-64, 66-67, 120-121, 308-338, 363-369, 371-373, 377, 484-486, 500-501, 513-518, 549-550, 558-559, 582, 588-616, 633, 635, 638-643, 670-673
Generated in workflow #2197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text size in container not calculated correctly depending on window.devicePixelRatio
1 participant