New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Sphinx 4 and Python 3.10 in GitHub tests #1509
Conversation
@choldgraf if this is branched from the latest So we could merge #1494 and then merge this given it's |
@mmcky gotcha - the main thing is that we need to make sure that the tests are actually passing with Sphinx 4, since we didn't add that to our github action in #1448 - if they do pass, and the only fails are the missing links that you've fixed in #1494 - then I'd be +1 on merging this and you can re-base on #1494 to make sure the tests are still passing there. Does that make sense? |
Yeah I noticed that you updated that. I have been testing in |
It looks like Python 3.10 isn't easily supported out of the box (unless somebody can decipher https://github.com/executablebooks/jupyter-book/pull/1509/checks?check_run_id=3901065796), maybe we'll need to wait for another package to be upgraded (I liked @chrisjsewell's idea that we only commit to supporting new versions within ~ 6 months of its release). In that case, I think @mmcky you should add https://github.com/executablebooks/jupyter-book/pull/1509/files#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957fL86-R87 to your PR in #1494 and we can track the Python 3.10 support in a future release. |
I agree I will move the needed changes @choldgraf |
Codecov Report
@@ Coverage Diff @@
## master #1509 +/- ##
=======================================
Coverage 91.17% 91.17%
=======================================
Files 7 7
Lines 680 680
=======================================
Hits 620 620
Misses 60 60
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
the failing test in 3.10 might be related to pytest-dev/pytest#8546 just realized that we are using an old version of pytest...I'm not sure why we've pinned that one, but let's try bumping to the latest version and see if that fixes this edit: upgrading pytest is also not trivial, I'll update the PR about Python 3.10 and close this |
This bumps our GHA test suite to use Sphinx 4 as a follow up to #1448 - it also adds a Python 3.10 test to the matrix. Let's see if tests pass.