Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 FIX: Porting regressions #141

Merged
merged 2 commits into from
Mar 10, 2021
Merged

馃悰 FIX: Porting regressions #141

merged 2 commits into from
Mar 10, 2021

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Mar 10, 2021

Comparing #140 to #110 I noticed a few mistaken regressions

@hukkinj1 did you notice anything else?

Comparing to #110 I noticed a few mistaken regressions
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #141 (8d11243) into master (29a8d5e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   96.51%   96.51%   -0.01%     
==========================================
  Files          72       72              
  Lines        3185     3183       -2     
==========================================
- Hits         3074     3072       -2     
  Misses        111      111              
Flag Coverage 螖
pytests 96.51% <100.00%> (-0.01%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
markdown_it/renderer.py 98.19% <酶> (-0.02%) 猬囷笍
markdown_it/rules_inline/strikethrough.py 97.40% <酶> (酶)
markdown_it/rules_inline/autolink.py 96.22% <100.00%> (-0.07%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 29a8d5e...8d11243. Read the comment docs.

@hukkin
Copy link
Member

hukkin commented Mar 10, 2021

Just what's in https://github.com/executablebooks/markdown-it-py/pull/110/files

So nothing major, just a missing newline and a trailing comma in a comment, besides what's already here.

@hukkin
Copy link
Member

hukkin commented Mar 10, 2021

I didn't do any deeper analysis though 馃槃 Just merged master to my old branch and noticed some unmerged changes.

@chrisjsewell chrisjsewell changed the title 馃悰 FIX: Port regression 馃悰 FIX: Porting regressions Mar 10, 2021
@chrisjsewell
Copy link
Member Author

So nothing major, just a missing newline and a trailing comma in a comment, besides what's already here.

yep added cheers 馃憤

@chrisjsewell chrisjsewell merged commit 9a06bfc into master Mar 10, 2021
@chrisjsewell chrisjsewell deleted the fix/regression branch March 10, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants