Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Enable RTD again #1129

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Apr 18, 2024

Let's keep this in draft so we can explore how to fix the RTD issues. Quick comment @rowanc1 can you keep the RTD project alive so that it can run on PRs. It is fine if it fails on main/other PRs due to a lack of .readthedocs.yaml file, it's just that it would be good to have it here so that we can explore all of the issues and potential solutions across the myst-theme repo (i.e. open a similar branch there and point packages.json to the repo branch where we can explore potential fixes)

TODO:

  • Write todo
  • The landing page of the preview is broken, due to some kind of javascript error
    @choldgraf Can you comment with a screenshot of this?
  • Bare links need to redirect to .html files: myst-to-react issue
    • Temporary solution would be to have the hosting provider do the redirect, but that is not ideal because local navigation of the static site through index.html is still broken
  • Overwrite robots.txt
    • Maybe this is to be done on the RTD settings?
  • Handle hydration issues: myst-to-react issue
  • Add flyout menu support

Closes #1133

Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
- npm run build
- npm run --workspace packages/mystmd link
- myst --version
- cd docs && myst build --html
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- cd docs && myst build --html
- cd docs && myst build --html --execute

Last time it was suggested to use --execute, but my understanding is that only affects the running of notebooks. For these issues it should not be relevant right? Is it also used in the mystmd pages?

@rowanc1
Copy link
Member

rowanc1 commented Apr 18, 2024

Thanks @LecrisUT for reopening this. @choldgraf I think you turned off the preview on RTD, are you in a place to re-enable?

@choldgraf
Copy link
Member

I can do that but just want to make sure that we are ready to do it. If I enable it then GitHub will mark every PR as failing until the rtd job is re enabled. Do we want that now or do we want to wait until we are actively fixing this before doing so?

@LecrisUT
Copy link
Contributor Author

Oh fair point. I can make a small page to redirect here that would be run on main and all other branches

@humitos
Copy link

humitos commented Apr 20, 2024

You can activate this branch in RTD without enabling the pull request build if you want. That way, this branch will be built on every commit on RTD... Getting an outcome similar to the PR builds.

@humitos
Copy link

humitos commented Apr 20, 2024

Overwrite robots.txt

You can do this by generating this file as you want and saving it at the root of the HTML output directory. More at https://docs.readthedocs.io/en/stable/reference/robots.html

@LecrisUT
Copy link
Contributor Author

It would not have the nice PR link to show it, and it would have to be on a new branch on the main repo, but that would work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadTheDocs hosting support
4 participants