Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update everything #160

Merged
merged 7 commits into from Aug 7, 2019
Merged

Update everything #160

merged 7 commits into from Aug 7, 2019

Conversation

minrk
Copy link
Collaborator

@minrk minrk commented Aug 6, 2019

this updates all dependencies for jupyterlab 1.0

  • switches bundle analyzer to maintained webpack-bundle-analyzer
  • updates shims and imports for new locations, unused additions (webpack tree-shaking really doesn't seem to work. Maybe this needs to be brought up upstream in jupyterlab, if there's something they can do to help).

The main tricky bit was the fact that webpack cannot transpile ES6 classes (i.e. jupyterlab dictates that all packages that use jupyterlab also target ES6, at least with webpack). This is a babel bug, as far as I can tell. The fix was to bump minimum browser versions such that ES6 classes are okay. This notably means that IE and opera mini won't work (I'm not sure they ever did, but the definitely won't now).

closes #159
closes #154
closes #153
closes #152
closes #151
closes #150
closes #149
closes #148
closes #146
closes #145
closes #141

@minrk
Copy link
Collaborator Author

minrk commented Aug 6, 2019

@SylvainCorlay I was able to run the widgets example, so I think this works okay. But if you know of API changes that I may have missed, let me know.

@SylvainCorlay
Copy link
Collaborator

@minrk this looks good to me.

I have ongoing work that goes a bit further, to make the Output widget and ipywidgets.interact work properly in thebelab, since it already does in voilà. My goal is to have the code for the two widget managers to converge. I think we can merge this and I will open a PR updating the widget manager when I am back from vacation.

@minrk
Copy link
Collaborator Author

minrk commented Aug 7, 2019

@SylvainCorlay sounds great, thanks!

@minrk minrk merged commit 0a049dd into master Aug 7, 2019
@minrk minrk deleted the update-all branch October 28, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants