add eslint rule to reduce node-fetch usage

expo · Sep 14, 2021 · 2463e95 · LinusU · Sep 14, 2021 · dsokal
1 parent 390e6fe
commit 2463e95
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -29,6 +29,10 @@ module.exports = {
             name: 'lodash',
             message: "Don't use lodash, it's heavy!",
           },
+          {
+            name: 'node-fetch',
+            message: 'Use got instead, node-fetch is used only for the GraphQL client.',
+          },
         ],
       },
     ],

diff --git a/packages/eas-cli/src/graphql/client.ts b/packages/eas-cli/src/graphql/client.ts
@@ -7,6 +7,9 @@ import {
   fetchExchange,
 } from '@urql/core';
 import { retryExchange } from '@urql/exchange-retry';
+// node-fetch is used here because @urql/core uses the fetch API under the hood
+// don't use node-fetch elsewhere
+// eslint-disable-next-line
 import fetch from 'node-fetch';
 
 import { getExpoApiBaseUrl } from '../api';