Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log dirty files in non-interactive when bailing #2288

Conversation

sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Mar 15, 2024

Why

https://linear.app/expo/issue/ENG-11730/dump-git-status-when-ci=1-and-we-abort-eas-build-due-to-dirty-working#comment-2c875628

How

Added git status logging when bailing on dirty repo in non-interactive mode.

Test Plan

Zrzut ekranu 2024-03-15 o 21 42 04

Copy link

linear bot commented Mar 15, 2024

Copy link

github-actions bot commented Mar 15, 2024

Size Change: +1.9 kB (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB +1.9 kB (0%)

compressed-size-action

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 53.96%. Comparing base (561e3bb) to head (047536f).
Report is 15 commits behind head on main.

Files Patch % Lines
packages/eas-cli/src/build/utils/repository.ts 14.29% 5 Missing and 1 partial ⚠️
packages/eas-cli/src/vcs/clients/git.ts 0.00% 3 Missing ⚠️
packages/eas-cli/src/build/configure.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/vcs/vcs.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2288      +/-   ##
==========================================
- Coverage   54.05%   53.96%   -0.08%     
==========================================
  Files         520      520              
  Lines       18953    18991      +38     
  Branches     3805     4010     +205     
==========================================
+ Hits        10243    10247       +4     
+ Misses       8689     8031     -658     
- Partials       21      713     +692     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjchmiela sjchmiela marked this pull request as ready for review March 15, 2024 20:42
@sjchmiela
Copy link
Contributor Author

/changelog-entry new-feature Print uncommitted files in non-interactive mode if they fail the execution.

@sjchmiela sjchmiela changed the title Log dirty files in non-interactive Log dirty files in non-interactive when bailing Mar 15, 2024
Copy link

✅ Thank you for adding the changelog entry!

Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sjchmiela sjchmiela merged commit 32848f6 into main Mar 18, 2024
9 checks passed
@sjchmiela sjchmiela deleted the stanley/eng-11730-dump-git-status-when-ci1-and-we-abort-eas-build-due-to-dirty branch March 18, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants