Add global mutation trigger field to EntityCompanionProvider #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Adding global mutation triggers to
EntityCompanionProvider
allows the creation of mutation triggers that run for every entity.How
I added the property
globalMutationTriggers
toEntityCompanionProvider
. In theEntityMutator
constructor, themutationTriggers
property is set to the combination ofcompanionProvider.globalMutationTriggers
and any mutation triggers included in the constructor's parameter. Global mutation triggers will always run before any mutation triggers defined for the individual entity.Test Plan
I modified
EntityMutator-test.ts
to include theglobalMutationTriggers
duringcreateEntityMutatorFactory
, and these global triggers have their trigger count verified later.