This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Fix release script #529
Merged
Fix release script #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of lacking support for npm 2FA (lerna/lerna#1091), our release script often fails and leaves behind a bad mess with tags to remove, working tree to clean and commits to reverse if you want to attempt again. This is kind of bad, if you need to make a release and you end up fighting the tools that are supposed to help with it, not make it more difficult.
This PR aims to fix some of the issues with the release script. Instead trying to use
lerna publishfor the whole process, we now calllerna versionto determine which packages to publish, bump versions and tag them in git. Then the script loops over all packages and finds those with a version not found in the npm registry and simply runsnpm publishto publish them, in topologically sorted order.npm publishhandles npm 2FA just fine, and prompts for a one time password, if needed, so 2FA should no longer be an issue.