-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Commit
…to babel-preset-expo (#24779) # Why - Reduce the boilerplate required for expo-router by moving the babel plugin features to babel-preset-expo. - Make the expo-constants Metro web support work without Expo Router. - Keeping expo-router/babel around for now since it shouldn't cause any harm, this will support if someone needs to use Expo Router v3 with Expo SDK 49 in the future (which probably won't work anyways). - Fix #23819 <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How - Move code from expo-router/babel.js to babel-preset-expo. - Rewrite plugin to use TypeScript. - Add tests. <!-- How did you build this feature or fix this bug and why? --> # Test Plan - Added tests for the new plugins. <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.