Skip to content

Commit

Permalink
[expo-notifications] Small fixes (#7069)
Browse files Browse the repository at this point in the history
# Why

Didn't want to put these changes inside another PR.

# How

- noticed a new version of `androidx:core` is available
- noticed that `"sound":false` in the notification request made the notification play a sound

# Test Plan

None, it just works.
  • Loading branch information
sjchmiela committed Mar 20, 2020
1 parent b3c659d commit 0433643
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/expo-notifications/android/build.gradle
Expand Up @@ -66,7 +66,7 @@ dependencies {
unimodule 'unimodules-permissions-interface'
unimodule 'unimodules-image-loader-interface'

api 'androidx.core:core:1.1.0'
api 'androidx.core:core:1.2.0'
api 'androidx.lifecycle:lifecycle-runtime:2.2.0'
api 'androidx.lifecycle:lifecycle-process:2.2.0'
api 'androidx.lifecycle:lifecycle-common-java8:2.2.0'
Expand Down
Expand Up @@ -42,7 +42,7 @@ protected void onReceiveResult(int resultCode, Bundle resultData) {
if (resultCode == BaseNotificationsService.SUCCESS_CODE) {
promise.resolve(null);
} else {
Exception e = resultData.getParcelable(BaseNotificationsService.EXCEPTION_KEY);
Exception e = (Exception) resultData.getSerializable(BaseNotificationsService.EXCEPTION_KEY);
promise.reject("ERR_NOTIFICATION_PRESENTATION_FAILED", "Notification could not be presented.", e);
}
}
Expand Down

0 comments on commit 0433643

Please sign in to comment.