Skip to content

Commit

Permalink
chore: drop unused web name property (#27437)
Browse files Browse the repository at this point in the history
# Why

- The `name` property is no longer used for anything, iirc it was
related to async debugging.
- `SyntheticPlatformEmitter` has been renamed to `DeviceEventEmitter`.
- In certain places, I've removed the web shim functions in favor of
nullish checks.

# Test Plan

- Should be pretty non-intrusive since all this code is unused.
- I don't think we have any web e2e tests left.

---------

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
  • Loading branch information
EvanBacon and expo-bot committed Mar 6, 2024
1 parent f14c8fe commit 0e03930
Show file tree
Hide file tree
Showing 334 changed files with 300 additions and 668 deletions.
2 changes: 2 additions & 0 deletions packages/expo-application/CHANGELOG.md
Expand Up @@ -10,6 +10,8 @@

### 💡 Others

- drop unused web `name` property. ([#27437](https://github.com/expo/expo/pull/27437) by [@EvanBacon](https://github.com/EvanBacon))

## 5.8.3 - 2024-01-18

_This version does not introduce any user-facing changes._
Expand Down
1 change: 0 additions & 1 deletion packages/expo-application/build/ExpoApplication.web.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/expo-application/build/ExpoApplication.web.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo-application/build/ExpoApplication.web.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/expo-application/src/ExpoApplication.web.ts
@@ -1,7 +1,4 @@
export default {
get name(): string {
return 'ExpoApplication';
},
get applicationName(): null {
return null;
},
Expand Down
2 changes: 2 additions & 0 deletions packages/expo-av/CHANGELOG.md
Expand Up @@ -12,6 +12,8 @@

### 💡 Others

- drop unused web `name` property. ([#27437](https://github.com/expo/expo/pull/27437) by [@EvanBacon](https://github.com/EvanBacon))

## 13.10.5 - 2024-02-06

### 🐛 Bug fixes
Expand Down
1 change: 0 additions & 1 deletion packages/expo-av/build/ExpoVideoManager.web.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo-av/build/ExpoVideoManager.web.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/expo-av/build/ExpoVideoManager.web.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo-av/build/ExpoVideoManager.web.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/expo-av/build/ExponentAV.web.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo-av/build/ExponentAV.web.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 3 additions & 6 deletions packages/expo-av/build/ExponentAV.web.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo-av/build/ExponentAV.web.js.map

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions packages/expo-av/src/ExpoVideoManager.web.ts
Expand Up @@ -3,9 +3,6 @@ import ExponentAV from './ExponentAV';
import { requestFullscreen, exitFullscreen } from './FullscreenUtils.web';

export default {
get name(): string {
return 'ExpoVideoManager';
},
get ScaleNone(): string {
return 'none';
},
Expand Down
9 changes: 3 additions & 6 deletions packages/expo-av/src/ExponentAV.web.ts
@@ -1,4 +1,4 @@
import { PermissionResponse, PermissionStatus, SyntheticPlatformEmitter } from 'expo-modules-core';
import { DeviceEventEmitter, PermissionResponse, PermissionStatus } from 'expo-modules-core';

import type { AVPlaybackNativeSource, AVPlaybackStatus, AVPlaybackStatusToSet } from './AV.types';
import type { RecordingStatus } from './Audio/Recording.types';
Expand Down Expand Up @@ -148,9 +148,6 @@ function getAudioRecorderDurationMillis() {
}

export default {
get name(): string {
return 'ExponentAV';
},
async getStatusForVideo(element: HTMLMediaElement): Promise<AVPlaybackStatus> {
return getStatusFromMedia(element);
},
Expand Down Expand Up @@ -190,14 +187,14 @@ export default {
const media = new Audio(source);

media.ontimeupdate = () => {
SyntheticPlatformEmitter.emit('didUpdatePlaybackStatus', {
DeviceEventEmitter.emit('didUpdatePlaybackStatus', {
key: media,
status: getStatusFromMedia(media),
});
};

media.onerror = () => {
SyntheticPlatformEmitter.emit('ExponentAV.onError', {
DeviceEventEmitter.emit('ExponentAV.onError', {
key: media,
error: media.error!.message,
});
Expand Down
2 changes: 2 additions & 0 deletions packages/expo-background-fetch/CHANGELOG.md
Expand Up @@ -10,6 +10,8 @@

### 💡 Others

- drop unused web `name` property. ([#27437](https://github.com/expo/expo/pull/27437) by [@EvanBacon](https://github.com/EvanBacon))

## 11.8.1 - 2024-01-26

_This version does not introduce any user-facing changes._
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/expo-background-fetch/src/ExpoBackgroundFetch.web.ts
@@ -1,9 +1,6 @@
import { BackgroundFetchStatus } from './BackgroundFetch.types';

export default {
get name(): string {
return 'ExpoBackgroundFetch';
},
async getStatusAsync(): Promise<BackgroundFetchStatus | null> {
return BackgroundFetchStatus.Restricted;
},
Expand Down
2 changes: 2 additions & 0 deletions packages/expo-barcode-scanner/CHANGELOG.md
Expand Up @@ -10,6 +10,8 @@

### 💡 Others

- drop unused web `name` property. ([#27437](https://github.com/expo/expo/pull/27437) by [@EvanBacon](https://github.com/EvanBacon))

## 12.9.3 - 2024-02-16

### 🎉 New features
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0e03930

Please sign in to comment.