[store-review] fix undef error in bare (#6713)

expo · Jan 8, 2020 · 11a48ca · 11a48ca
1 parent aefcafe
commit 11a48ca
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 9 deletions.
diff --git a/docs/pages/versions/unversioned/sdk/storereview.md b/docs/pages/versions/unversioned/sdk/storereview.md
@@ -48,6 +48,8 @@ StoreReview.isAvailableAsync();
 
 This uses the `Constants` API to get the `Constants.manifest.ios.appStoreUrl` on iOS, or the `Constants.manifest.android.playStoreUrl` on Android.
 
+In the bare workflow, this will return `null`.
+
 #### Example
 
 ```js
@@ -56,12 +58,12 @@ const url = StoreReview.storeUrl();
 
 ### `StoreReview.hasAction()`
 
-This returns a boolean that let's you know if the module can perform any action. This is used for cases where the `app.json` doesn't have the proper fields, and `StoreReview.isAvailableAsync()` returns false.
+This returns a promise that resolves to a boolean that let's you know if the module can perform any action. This is used for cases where the `app.json` doesn't have the proper fields, and `StoreReview.isAvailableAsync()` returns false.
 
 #### Example
 
 ```js
-if (StoreReview.hasAction()) {
+if (await StoreReview.hasAction()) {
 }
 ```
 

diff --git a/docs/pages/versions/v36.0.0/sdk/storereview.md b/docs/pages/versions/v36.0.0/sdk/storereview.md
@@ -48,6 +48,8 @@ StoreReview.isAvailableAsync();
 
 This uses the `Constants` API to get the `Constants.manifest.ios.appStoreUrl` on iOS, or the `Constants.manifest.android.playStoreUrl` on Android.
 
+In the bare workflow, this will return `null`.
+
 #### Example
 
 ```js
@@ -56,12 +58,12 @@ const url = StoreReview.storeUrl();
 
 ### `StoreReview.hasAction()`
 
-This returns a boolean that let's you know if the module can perform any action. This is used for cases where the `app.json` doesn't have the proper fields, and `StoreReview.isAvailableAsync()` returns false.
+This returns a promise that resolves to a boolean that let's you know if the module can perform any action. This is used for cases where the `app.json` doesn't have the proper fields, and `StoreReview.isAvailableAsync()` returns false.
 
 #### Example
 
 ```js
-if (StoreReview.hasAction()) {
+if (await StoreReview.hasAction()) {
 }
 ```
 

diff --git a/packages/expo-store-review/build/StoreReview.js b/packages/expo-store-review/build/StoreReview.js
diff --git a/packages/expo-store-review/build/StoreReview.js.map b/packages/expo-store-review/build/StoreReview.js.map
diff --git a/packages/expo-store-review/src/StoreReview.ts b/packages/expo-store-review/src/StoreReview.ts
@@ -56,9 +56,11 @@ export async function requestReview(): Promise<void> {
  */
 export function storeUrl(): string | null {
   const { manifest } = Constants;
-  if (Platform.OS === 'ios' && manifest.ios) {
+  // eslint-disable-next-line no-undef
+  if (Platform.OS === 'ios' && manifest?.ios) {
     return manifest.ios.appStoreUrl;
-  } else if (Platform.OS === 'android' && manifest.android) {
+    // eslint-disable-next-line no-undef
+  } else if (Platform.OS === 'android' && manifest?.android) {
     return manifest.android.playStoreUrl;
   } else {
     return null;