Skip to content

Commit

Permalink
fix(web): Allow createElement & unstable_createElement usage
Browse files Browse the repository at this point in the history
  • Loading branch information
wood1986 committed May 5, 2020
1 parent ea6c740 commit 12adc9d
Show file tree
Hide file tree
Showing 13 changed files with 43 additions and 13 deletions.
4 changes: 4 additions & 0 deletions packages/expo-gl/CHANGELOG.md
Expand Up @@ -2,6 +2,10 @@

## master

### 🐛 Bug fixes

- Allow createElement & unstable_createElement usage for web. ([#7995](https://github.com/expo/expo/pull/7995) by [@wood1986](https://github.com/wood1986))

### 🛠 Breaking changes

### 🎉 New features
Expand Down
4 changes: 3 additions & 1 deletion packages/expo-gl/build/Canvas.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo-gl/build/Canvas.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions packages/expo-gl/build/GLView.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/expo-gl/build/createElement.native.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions packages/expo-gl/build/createElement.native.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/expo-gl/build/createElement.native.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions packages/expo-gl/build/createElement.web.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions packages/expo-gl/build/createElement.web.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/expo-gl/build/createElement.web.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 4 additions & 8 deletions packages/expo-gl/src/Canvas.tsx
@@ -1,13 +1,9 @@
import * as React from 'react';
import { findDOMNode } from 'react-dom';
import {
createElement,
LayoutChangeEvent,
PixelRatio,
StyleSheet,
View,
ViewProps,
} from 'react-native';
import { LayoutChangeEvent, PixelRatio, StyleSheet, View, ViewProps } from 'react-native';

// @ts-ignore
import { createElement } from './createElement';

function getElement(component) {
try {
Expand Down
1 change: 1 addition & 0 deletions packages/expo-gl/src/createElement.native.tsx
@@ -0,0 +1 @@
export { createElement } from 'react-native';
11 changes: 11 additions & 0 deletions packages/expo-gl/src/createElement.web.tsx
@@ -0,0 +1,11 @@
// Due to https://github.com/necolas/react-native-web/blob/5287044f403d881a13e17f140c5575ce0661587f/packages/react-native-web/src/index.js#L1
// See https://github.com/react-native-community/react-native-svg/blob/develop/src/ReactNativeSVG.web.ts

import {
// @ts-ignore
unstable_createElement as ucE,
// @ts-ignore
createElement as cE,
} from 'react-native';

export const createElement = cE || ucE;

0 comments on commit 12adc9d

Please sign in to comment.