Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[docs] Fix caption not shown on
Video
(#27943)
# Why <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> We recently updated Video component to add a border radius as per our styleguide. We also introduced adding a caption at the bottom of a video in #26064. Since the latter PR was created before the former, setting `overflow: hidden` also hides the `caption`. This PR takes `<p>` that is used to display the caption outside of the `<div>` on which `overflow` is used. It also creates wrapper `<div>` to preserve the initial `margin-bottom`. # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> Run docs locally and see http://localhost:3002/review/with-orbit/ (this is the page where we use `caption`). ## Preview ![CleanShot 2024-03-29 at 21 09 06@2x](https://github.com/expo/expo/assets/10234615/356795b6-4768-4076-9346-60c07e66ba9f) # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
- Loading branch information