Commit
expo-gl
(#7550)
# Why #7502 reminded me that we should have better logging/debugging options for `expo-gl` as we don't log anything by default and, most importantly, we don't log any errors like all web browsers do. # How - Removed `gl.enableLogging` -> it isn't a part of WebGL specification so imho it should somehow indicate itself as Expo-specific. We don't need to deprecate it first as it wasn't documented. - Added `gl.__expoSetLogging` method which receives bitwise enum `GLLoggingOption` (check out tsdoc comments for more details). - Moved the code responsible for logging to separate file (called `GLUtils`, because I believe we can put more stuff there soon). - Slightly improved how WebGL objects are being stringified by us. Some of them were being logged as `[object Object]`. - Added a few missing TypeScript property declarations. # Test Plan Tested by adding `gl.__expoSetLogging` method call to NCL example and playing with some custom `GLLoggingOption` values.
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.