[expo-updates] improve error messaging in the case where an app is bu…

…ilt without having run expo publish
expo · Mar 17, 2020 · 774e642 · 774e642
1 parent 5b1f4c2
commit 774e642
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/packages/expo-updates/android/src/main/java/expo/modules/updates/UpdatesController.java b/packages/expo-updates/android/src/main/java/expo/modules/updates/UpdatesController.java
@@ -260,7 +260,7 @@ public synchronized void start(final Context context) {
     }
 
     if (mUpdatesConfiguration.getUpdateUrl() == null) {
-      throw new AssertionError("expo-updates is enabled, but no valid updateUrl is configured. Please set a valid URL in AndroidManifest.xml or when initializing UpdatesController.");
+      throw new AssertionError("expo-updates is enabled, but no valid updateUrl is configured in AndroidManifest.xml. If you are making a release build for the first time, make sure you have run `expo publish` at least once.");
     }
 
     boolean shouldCheckForUpdate = UpdatesUtils.shouldCheckForUpdateOnLaunch(mUpdatesConfiguration, context);

diff --git a/packages/expo-updates/android/src/main/java/expo/modules/updates/loader/EmbeddedLoader.java b/packages/expo-updates/android/src/main/java/expo/modules/updates/loader/EmbeddedLoader.java
@@ -70,6 +70,7 @@ public static Manifest readEmbeddedManifest(Context context) {
         sEmbeddedManifest = ManifestFactory.getManifest(context, new JSONObject(manifestString));
       } catch (Exception e) {
         Log.e(TAG, "Could not read embedded manifest", e);
+        throw new AssertionError("The embedded manifest is invalid or could not be read. If you are making a release build for the first time, make sure you have run `expo publish` at least once.");
       }
     }
 

diff --git a/packages/expo-updates/ios/EXUpdates/AppLoader/EXUpdatesEmbeddedAppLoader.m b/packages/expo-updates/ios/EXUpdates/AppLoader/EXUpdatesEmbeddedAppLoader.m
@@ -28,6 +28,11 @@ + (nullable EXUpdatesUpdate *)embeddedManifest
       } else {
         NSAssert([manifest isKindOfClass:[NSDictionary class]], @"embedded manifest should be a valid JSON file");
         embeddedManifest = [EXUpdatesUpdate updateWithManifest:(NSDictionary *)manifest];
+        if (!embeddedManifest.updateId) {
+          @throw [NSException exceptionWithName:NSInternalInconsistencyException
+                                         reason:@"The embedded manifest is invalid. If you are making a release build for the first time, make sure you have run `expo publish` at least once."
+                                       userInfo:@{}];
+        }
       }
     }
   });

diff --git a/packages/expo-updates/ios/EXUpdates/EXUpdatesAppController.m b/packages/expo-updates/ios/EXUpdates/EXUpdatesAppController.m
@@ -92,7 +92,7 @@ - (void)start
 
   if (!EXUpdatesConfig.sharedInstance.updateUrl) {
     @throw [NSException exceptionWithName:NSInternalInconsistencyException
-                                   reason:@"expo-updates is enabled, but no valid URL is configured under EXUpdatesURL."
+                                   reason:@"expo-updates is enabled, but no valid URL is configured under EXUpdatesURL. If you are making a release build for the first time, make sure you have run `expo publish` at least once."
                                  userInfo:@{}];
   }