[expo-gl-cpp] fix crash in react-native 0.62 (#8352)

* [expo-gl-cpp] fix crash in react-native 0.62 * [expo-gl-cpp] update CHANGELOG
expo · May 20, 2020 · 7fbde60 · 7fbde60
1 parent 8ecc6ae
commit 7fbde60
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 3 deletions.
diff --git a/packages/expo-gl-cpp/android/dist/arm64-v8a/libexpo-gl.so b/packages/expo-gl-cpp/android/dist/arm64-v8a/libexpo-gl.so
diff --git a/packages/expo-gl-cpp/android/dist/armeabi-v7a/libexpo-gl.so b/packages/expo-gl-cpp/android/dist/armeabi-v7a/libexpo-gl.so
diff --git a/packages/expo-gl-cpp/android/dist/x86/libexpo-gl.so b/packages/expo-gl-cpp/android/dist/x86/libexpo-gl.so
diff --git a/packages/expo-gl-cpp/android/dist/x86_64/libexpo-gl.so b/packages/expo-gl-cpp/android/dist/x86_64/libexpo-gl.so
diff --git a/packages/expo-gl-cpp/cpp/EXGLContext.cpp b/packages/expo-gl-cpp/cpp/EXGLContext.cpp
@@ -48,9 +48,7 @@ UEXGLContextId EXGLContext::ContextCreate(JSGlobalContextRef jsCtx) {
     jsEXGLContextMap = JSObjectMake(jsCtx, nullptr, nullptr);
     EXJSObjectSetValueWithUTF8CStringName(jsCtx, jsGlobal, "__EXGLContexts", jsEXGLContextMap);
   }
-  std::stringstream ss;
-  ss << exglCtxId;
-  auto exglCtxIdStr = ss.str();
+  auto exglCtxIdStr = std::to_string(exglCtxId);
   EXJSObjectSetValueWithUTF8CStringName(jsCtx, jsEXGLContextMap,
                                         exglCtxIdStr.c_str(), exglCtx->getJSObject());
 

diff --git a/packages/expo-gl/CHANGELOG.md b/packages/expo-gl/CHANGELOG.md
@@ -10,5 +10,6 @@
 
 ### 🐛 Bug fixes
 
+- Fix crash in React Native 0.62 when creating a context. ([#8352](https://github.com/expo/expo/pull/8352) by [@wkozyra95](https://github.com/wkozyra95))
 - Allow createElement & unstable_createElement usage for web. ([#7995](https://github.com/expo/expo/pull/7995) by [@wood1986](https://github.com/wood1986))
 - Fix depth/stencil buffers not working correctly with `three.js`. ([#7543](https://github.com/expo/expo/pull/7543) by [@tsapeta](https://github.com/tsapeta))