[expo-notification] Prevent from notification being dispatch twice (#…

…8437) * [expo-notification] Prevent from notification being dispatch twice * [expo-notifications] Apply requested changes * [expo-notifications] Check SDK version * [expo-notifications] Rename * [expo-notifications] Check sdk version * [expo-notifications] Apply requested changes
expo · May 22, 2020 · 915140a · 915140a
1 parent 0f614f8
commit 915140a
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 0 deletions.
diff --git a/android/expoview/src/main/java/host/exp/exponent/fcm/ExpoFcmMessagingService.java b/android/expoview/src/main/java/host/exp/exponent/fcm/ExpoFcmMessagingService.java
@@ -1,16 +1,24 @@
 package host.exp.exponent.fcm;
 
+import android.util.Log;
+
 import com.google.firebase.messaging.RemoteMessage;
 
+import org.json.JSONException;
+import org.json.JSONObject;
+
 import java.util.Map;
 
 import expo.modules.notifications.FirebaseListenerService;
 import expo.modules.notifications.notifications.model.NotificationContent;
 import expo.modules.notifications.notifications.model.NotificationRequest;
 import expo.modules.notifications.notifications.model.triggers.FirebaseNotificationTrigger;
+import host.exp.exponent.ABIVersion;
 import host.exp.exponent.Constants;
 import host.exp.exponent.kernel.ExperienceId;
 import host.exp.exponent.notifications.PushNotificationHelper;
+import host.exp.exponent.storage.ExperienceDBObject;
+import host.exp.exponent.storage.ExponentDB;
 import versioned.host.exp.exponent.modules.universal.notifications.ScopedNotificationRequest;
 
 public class ExpoFcmMessagingService extends FirebaseListenerService {
@@ -31,7 +39,51 @@ public void onMessageReceived(RemoteMessage remoteMessage) {
       return;
     }
 
+    ExponentDB.experienceIdToExperience(remoteMessage.getData().get("experienceId"), new ExponentDB.ExperienceResultListener() {
+      @Override
+      public void onSuccess(ExperienceDBObject experience) {
+        try {
+          JSONObject manifest = new JSONObject(experience.manifest);
+          int sdkVersion = ABIVersion.toNumber(manifest.getString("sdkVersion"));
+
+          // If an experience is on SDK newer than 38, that is SDK39 and beyond up till UNVERSIONED
+          // we only use the new notifications API as it is going to be removed from SDK39.
+          if (sdkVersion >= 39) {
+            dispatchToNextNotificationModule(remoteMessage);
+            return;
+          } else if (sdkVersion == 38) {
+            // In SDK38 we want to let people decide which notifications API to use,
+            // the next or the legacy one.
+            JSONObject androidSection = manifest.optJSONObject("android");
+            if (androidSection != null) {
+              boolean useNextNotificationsApi = androidSection.optBoolean("useNextNotificationsApi", false);
+              if (useNextNotificationsApi) {
+                dispatchToNextNotificationModule(remoteMessage);
+                return;
+              }
+            }
+          }
+          // If it's an older experience or useNextNotificationsApi is set to false, let's use the legacy notifications API
+          dispatchToLegacyNotificationModule(remoteMessage);
+        } catch (JSONException e) {
+          e.printStackTrace();
+          onFailure();
+        }
+      }
+
+      @Override
+      public void onFailure() {
+        Log.w("expo-notifications", "Couldn't get experience from remote message.", null);
+        dispatchToLegacyNotificationModule(remoteMessage);
+      }
+    });
+  }
+
+  private void dispatchToNextNotificationModule(RemoteMessage remoteMessage) {
     super.onMessageReceived(remoteMessage);
+  }
+
+  private void dispatchToLegacyNotificationModule(RemoteMessage remoteMessage) {
     PushNotificationHelper.getInstance().onMessageReceived(this, remoteMessage.getData().get("experienceId"), remoteMessage.getData().get("channelId"), remoteMessage.getData().get("message"), remoteMessage.getData().get("body"), remoteMessage.getData().get("title"), remoteMessage.getData().get("categoryId"));
   }
 

diff --git a/apps/test-suite/app.json b/apps/test-suite/app.json
@@ -8,6 +8,9 @@
     "platforms": ["android", "ios", "web"],
     "ios": {
       "bundleIdentifier": "io.expo.testsuite"
+    },
+    "android": {
+      "useNextNotificationsApi": true
     }
   }
 }