[ems][jest-expo-enzyme] Deprecate the library and remove it from EMS (#…

…19777)
expo · Oct 30, 2022 · 9e30274 · 9e30274
1 parent fe3bd0d
commit 9e30274
Show file tree

Hide file tree

Showing 13 changed files with 363 additions and 218 deletions.
diff --git a/packages/expo-module-scripts/CHANGELOG.md b/packages/expo-module-scripts/CHANGELOG.md
@@ -10,6 +10,8 @@
 
 ### 💡 Others
 
+- Remove Enzyme plugin - it does not work with React 18. Not considered a breaking change because the Enzyme plugin has never worked with React 18 and so is already broken. ([#19777](https://github.com/expo/expo/pull/19777) by [@brentvatne](https://github.com/brentvatne))
+
 ## 3.0.1 — 2022-10-28
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-module-scripts/enzyme/jest-preset.js b/packages/expo-module-scripts/enzyme/jest-preset.js
diff --git a/packages/expo-module-scripts/package.json b/packages/expo-module-scripts/package.json
@@ -37,7 +37,6 @@
     "find-yarn-workspace-root": "^2.0.0",
     "glob": "^7.1.7",
     "jest-expo": "~47.0.0",
-    "jest-expo-enzyme": "^1.2.3",
     "jest-watch-typeahead": "0.6.4",
     "ts-jest": "~26.3.0",
     "typescript": "^4.3.5"

diff --git a/packages/html-elements/package.json b/packages/html-elements/package.json
@@ -33,7 +33,17 @@
   "license": "MIT",
   "homepage": "https://github.com/expo/expo/tree/main/packages/html-elements",
   "jest": {
-    "preset": "expo-module-scripts/enzyme"
+    "projects": [
+      {
+        "preset": "jest-expo/ios"
+      },
+      {
+        "preset": "jest-expo/android"
+      },
+      {
+        "preset": "jest-expo/web"
+      }
+    ]
   },
   "devDependencies": {
     "expo-module-scripts": "^3.0.0"

diff --git a/packages/html-elements/src/elements/__tests__/__snapshots__/Headings-test.tsx.snap.android b/packages/html-elements/src/elements/__tests__/__snapshots__/Headings-test.tsx.snap.android
@@ -4,11 +4,14 @@ exports[`renders H1 1`] = `
 <Text
   accessibilityRole="header"
   style={
-    Object {
-      "fontSize": 64,
-      "fontWeight": "bold",
-      "marginVertical": 21.44,
-    }
+    Array [
+      Object {
+        "fontSize": 64,
+        "fontWeight": "bold",
+        "marginVertical": 21.44,
+      },
+      undefined,
+    ]
   }
 />
 `;
@@ -17,11 +20,14 @@ exports[`renders H2 1`] = `
 <Text
   accessibilityRole="header"
   style={
-    Object {
-      "fontSize": 48,
-      "fontWeight": "bold",
-      "marginVertical": 26.56,
-    }
+    Array [
+      Object {
+        "fontSize": 48,
+        "fontWeight": "bold",
+        "marginVertical": 26.56,
+      },
+      undefined,
+    ]
   }
 />
 `;
@@ -30,11 +36,14 @@ exports[`renders H3 1`] = `
 <Text
   accessibilityRole="header"
   style={
-    Object {
-      "fontSize": 37.44,
-      "fontWeight": "bold",
-      "marginVertical": 32,
-    }
+    Array [
+      Object {
+        "fontSize": 37.44,
+        "fontWeight": "bold",
+        "marginVertical": 32,
+      },
+      undefined,
+    ]
   }
 />
 `;
@@ -43,11 +52,14 @@ exports[`renders H4 1`] = `
 <Text
   accessibilityRole="header"
   style={
-    Object {
-      "fontSize": 32,
-      "fontWeight": "bold",
-      "marginVertical": 42.56,
-    }
+    Array [
+      Object {
+        "fontSize": 32,
+        "fontWeight": "bold",
+        "marginVertical": 42.56,
+      },
+      undefined,
+    ]
   }
 />
 `;
@@ -56,11 +68,14 @@ exports[`renders H5 1`] = `
 <Text
   accessibilityRole="header"
   style={
-    Object {
-      "fontSize": 26.56,
-      "fontWeight": "bold",
-      "marginVertical": 53.44,
-    }
+    Array [
+      Object {
+        "fontSize": 26.56,
+        "fontWeight": "bold",
+        "marginVertical": 53.44,
+      },
+      undefined,
+    ]
   }
 />
 `;
@@ -69,11 +84,14 @@ exports[`renders H6 1`] = `
 <Text
   accessibilityRole="header"
   style={
-    Object {
-      "fontSize": 21.44,
-      "fontWeight": "bold",
-      "marginVertical": 74.56,
-    }
+    Array [
+      Object {
+        "fontSize": 21.44,
+        "fontWeight": "bold",
+        "marginVertical": 74.56,
+      },
+      undefined,
+    ]
   }
 />
 `;
diff --git a/packages/html-elements/src/elements/__tests__/__snapshots__/Headings-test.tsx.snap.ios b/packages/html-elements/src/elements/__tests__/__snapshots__/Headings-test.tsx.snap.ios
@@ -4,11 +4,14 @@ exports[`renders H1 1`] = `
 <Text
   accessibilityRole="header"
   style={
-    Object {
-      "fontSize": 64,
-      "fontWeight": "bold",
-      "marginVertical": 21.44,
-    }
+    Array [
+      Object {
+        "fontSize": 64,
+        "fontWeight": "bold",
+        "marginVertical": 21.44,
+      },
+      undefined,
+    ]
   }
 />
 `;
@@ -17,11 +20,14 @@ exports[`renders H2 1`] = `
 <Text
   accessibilityRole="header"
   style={
-    Object {
-      "fontSize": 48,
-      "fontWeight": "bold",
-      "marginVertical": 26.56,
-    }
+    Array [
+      Object {
+        "fontSize": 48,
+        "fontWeight": "bold",
+        "marginVertical": 26.56,
+      },
+      undefined,
+    ]
   }
 />
 `;
@@ -30,11 +36,14 @@ exports[`renders H3 1`] = `
 <Text
   accessibilityRole="header"
   style={
-    Object {
-      "fontSize": 37.44,
-      "fontWeight": "bold",
-      "marginVertical": 32,
-    }
+    Array [
+      Object {
+        "fontSize": 37.44,
+        "fontWeight": "bold",
+        "marginVertical": 32,
+      },
+      undefined,
+    ]
   }
 />
 `;
@@ -43,11 +52,14 @@ exports[`renders H4 1`] = `
 <Text
   accessibilityRole="header"
   style={
-    Object {
-      "fontSize": 32,
-      "fontWeight": "bold",
-      "marginVertical": 42.56,
-    }
+    Array [
+      Object {
+        "fontSize": 32,
+        "fontWeight": "bold",
+        "marginVertical": 42.56,
+      },
+      undefined,
+    ]
   }
 />
 `;
@@ -56,11 +68,14 @@ exports[`renders H5 1`] = `
 <Text
   accessibilityRole="header"
   style={
-    Object {
-      "fontSize": 26.56,
-      "fontWeight": "bold",
-      "marginVertical": 53.44,
-    }
+    Array [
+      Object {
+        "fontSize": 26.56,
+        "fontWeight": "bold",
+        "marginVertical": 53.44,
+      },
+      undefined,
+    ]
   }
 />
 `;
@@ -69,11 +84,14 @@ exports[`renders H6 1`] = `
 <Text
   accessibilityRole="header"
   style={
-    Object {
-      "fontSize": 21.44,
-      "fontWeight": "bold",
-      "marginVertical": 74.56,
-    }
+    Array [
+      Object {
+        "fontSize": 21.44,
+        "fontWeight": "bold",
+        "marginVertical": 74.56,
+      },
+      undefined,
+    ]
   }
 />
 `;
diff --git a/packages/html-elements/src/elements/__tests__/__snapshots__/Rules-test.tsx.snap.android b/packages/html-elements/src/elements/__tests__/__snapshots__/Rules-test.tsx.snap.android
@@ -3,13 +3,16 @@
 exports[`renders HR 1`] = `
 <View
   style={
-    Object {
-      "borderBottomColor": "#EEEEEE",
-      "borderBottomWidth": 0.5,
-      "borderTopColor": "#9A9A9A",
-      "borderTopWidth": 0.5,
-      "marginVertical": 8,
-    }
+    Array [
+      Object {
+        "borderBottomColor": "#EEEEEE",
+        "borderBottomWidth": 0.5,
+        "borderTopColor": "#9A9A9A",
+        "borderTopWidth": 0.5,
+        "marginVertical": 8,
+      },
+      undefined,
+    ]
   }
 />
 `;
diff --git a/packages/html-elements/src/elements/__tests__/__snapshots__/Rules-test.tsx.snap.ios b/packages/html-elements/src/elements/__tests__/__snapshots__/Rules-test.tsx.snap.ios
@@ -3,13 +3,16 @@
 exports[`renders HR 1`] = `
 <View
   style={
-    Object {
-      "borderBottomColor": "#EEEEEE",
-      "borderBottomWidth": 0.5,
-      "borderTopColor": "#9A9A9A",
-      "borderTopWidth": 0.5,
-      "marginVertical": 8,
-    }
+    Array [
+      Object {
+        "borderBottomColor": "#EEEEEE",
+        "borderBottomWidth": 0.5,
+        "borderTopColor": "#9A9A9A",
+        "borderTopWidth": 0.5,
+        "marginVertical": 8,
+      },
+      undefined,
+    ]
   }
 />
 `;