Fix #28043, crash caused by unnecessary permissions check (#28045)

expo · Apr 5, 2024 · a07d1b9 · a07d1b9
1 parent 33ad580
commit a07d1b9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/packages/expo-sensors/CHANGELOG.md b/packages/expo-sensors/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Prevent unnecessary permissions check when moving app to background (Would crash with certain configs). ([#28045](https://github.com/expo/expo/pull/28045) by [@cltnschlosser](https://github.com/cltnschlosser))
+
 ### 💡 Others
 
 - drop unused web `name` property. ([#27437](https://github.com/expo/expo/pull/27437) by [@EvanBacon](https://github.com/EvanBacon))

diff --git a/packages/expo-sensors/ios/PedometerModule.swift b/packages/expo-sensors/ios/PedometerModule.swift
@@ -101,16 +101,15 @@ public final class PedometerModule: Module {
   }
 
   private func stopUpdates() {
-    guard let permissions = appContext?.permissions else {
+    guard watchHandler != nil,
+      let permissions = appContext?.permissions,
+      permissions.hasGrantedPermission(usingRequesterClass: EXMotionPermissionRequester.self) else {
       return
     }
-    if permissions.hasGrantedPermission(usingRequesterClass: EXMotionPermissionRequester.self) {
-      if watchHandler != nil {
-        pedometer.stopUpdates()
-        watchStartDate = nil
-        watchHandler = nil
-      }
-    }
+
+    pedometer.stopUpdates()
+    watchStartDate = nil
+    watchHandler = nil
   }
 }