[android] Update ReactCommon

expo · May 28, 2020 · a40e961 · a40e961
1 parent 6bf3082
commit a40e961
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 20 deletions.
diff --git a/android/ReactCommon/jsi/JSCRuntime.cpp b/android/ReactCommon/jsi/JSCRuntime.cpp
@@ -319,15 +319,6 @@ JSStringRef getIsArrayString() {
 #endif
 } // namespace
 
-// std::string utility
-namespace {
-std::string to_string(void* value) {
-  std::ostringstream ss;
-  ss << value;
-  return ss.str();
-}
-} // namespace
-
 JSCRuntime::JSCRuntime()
     : JSCRuntime(JSGlobalContextCreateInGroup(nullptr, nullptr)) {
   JSGlobalContextRelease(ctx_);
@@ -405,7 +396,7 @@ jsi::Object JSCRuntime::global() {
 
 std::string JSCRuntime::description() {
   if (desc_.empty()) {
-    desc_ = std::string("<JSCRuntime@") + to_string(this) + ">";
+    desc_ = std::string("<JSCRuntime@") + std::to_string(reinterpret_cast<std::uintptr_t>(this)) + ">";
   }
   return desc_;
 }

diff --git a/android/versioned-react-native/ReactCommon/jsi/JSCRuntime.cpp b/android/versioned-react-native/ReactCommon/jsi/JSCRuntime.cpp
@@ -319,15 +319,6 @@ JSStringRef getIsArrayString() {
 #endif
 } // namespace
 
-// std::string utility
-namespace {
-std::string to_string(void* value) {
-  std::ostringstream ss;
-  ss << value;
-  return ss.str();
-}
-} // namespace
-
 JSCRuntime::JSCRuntime()
     : JSCRuntime(JSGlobalContextCreateInGroup(nullptr, nullptr)) {
   JSGlobalContextRelease(ctx_);
@@ -405,7 +396,7 @@ jsi::Object JSCRuntime::global() {
 
 std::string JSCRuntime::description() {
   if (desc_.empty()) {
-    desc_ = std::string("<JSCRuntime@") + to_string(this) + ">";
+    desc_ = std::string("<JSCRuntime@") + std::to_string(reinterpret_cast<std::uintptr_t>(this)) + ">";
   }
   return desc_;
 }