[expo-permissions][android] Fix brightness permission (#7276)

* [expo-permissions][android] Fix brightness permission * [expo-permissions] Update changelog.md
expo · Mar 9, 2020 · ab17510 · ab17510
1 parent 0303461
commit ab17510
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,8 @@ This is the log of notable changes to the Expo client that are developer-facing.
 
 ### 🐛 Bug fixes
 
+- Fixed `Brightness.requestPermissionsAsync` throwing `permission cannot be null or empty` error on Android. ([#7276](https://github.com/expo/expo/pull/7276) by [@lukmccall](https://github.com/lukmccall))
+
 ## 37.0.0
 
 ### 📚 3rd party library updates

diff --git a/...ges/expo-permissions/android/src/main/java/expo/modules/permissions/PermissionsService.kt b/...ges/expo-permissions/android/src/main/java/expo/modules/permissions/PermissionsService.kt
@@ -287,8 +287,13 @@ open class PermissionsService(val context: Context) : InternalModule, Permission
     mAskAsyncListener = null
     mAskAsyncRequestedPermissions = null
 
-    // invoke actual asking for permissions
-    askForManifestPermissions(askAsyncRequestedPermissions, askAsyncListener)
+    if (askAsyncRequestedPermissions.isNotEmpty()) {
+      // invoke actual asking for permissions
+      askForManifestPermissions(askAsyncRequestedPermissions, askAsyncListener)
+    } else {
+      // user asked only for Manifest.permission.WRITE_SETTINGS
+      askAsyncListener.onResult(mutableMapOf())
+    }
   }
 
   override fun onHostPause() = Unit