[danger] Fix pr author and ignore all CHANGELOG.md files in CODEOWNERS (

#8197) * [danger] Fix pr author and ignore all CHANGELOG.md files in CODEOWNERS * Apply requested changes Co-authored-by: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com> Co-authored-by: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com>
expo · May 11, 2020 · bf9a495 · bf9a495
1 parent a4f269a
commit bf9a495
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -1,3 +1,6 @@
+# Ignore CHANGELOG.md files to prevent Danger.js from triggering code owner reviews
+/packages/**/CHANGELOG.md                       @ghost
+
 /packages/@unimodules/core                      @sjchmiela @tsapeta
 /packages/@unimodules/react-native-adapter      @sjchmiela @tsapeta
 /packages/babel-preset-expo                     @brentvatne

diff --git a/dangerfile.ts b/dangerfile.ts
@@ -2,7 +2,7 @@ import { checkChangelog } from '@expo/danger';
 
 const allowedUsers = ['lukmccall', 'sjchmiela', 'tsapeta', 'bbarthec', 'mczernek'];
 // eslint-disable-next-line no-undef
-const prAuthor = danger.github.pr.base.user.login;
+const prAuthor = danger.github.pr.user.login;
 if (allowedUsers.includes(prAuthor)) {
   checkChangelog();
 }
diff --git a/packages/danger/build/ChangelogChecker.js b/packages/danger/build/ChangelogChecker.js
diff --git a/packages/danger/build/ChangelogChecker.js.map b/packages/danger/build/ChangelogChecker.js.map
diff --git a/packages/danger/src/ChangelogChecker.ts b/packages/danger/src/ChangelogChecker.ts
@@ -23,7 +23,7 @@ export type FixedChangelogEntry = PackageChangelogEntry & { content: string; dif
 
 // Setup
 const pr = danger.github.pr;
-const prAuthor = pr.base.user.login;
+const prAuthor = pr.user.login;
 const pullRequestManager = createPullRequestManager(danger.github.api, pr);
 
 async function getFileDiffAsync(path): Promise<string> {