Fix example, make string comparisons safer.

expo · Mar 2, 2020 · c439667 · c439667
1 parent fcac96e
commit c439667
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/apps/native-component-list/src/screens/WebBrowserScreen.tsx b/apps/native-component-list/src/screens/WebBrowserScreen.tsx
@@ -102,10 +102,7 @@ export default class WebBrowserScreen extends React.Component<{}, State> {
       readerMode: this.state.readerMode,
       enableDefaultShare: this.state.enableDefaultShare,
     };
-    const result = await WebBrowser.openBrowserAsync(
-      'https://proandroiddev.com/say-no-to-baseactivity-and-basefragment-83b156ed8998?source=grid_home----c72404660798-----0-1-----------------18---39b94dfe_9ccf_4e8c_803f_bcf970042e56--',
-      args
-    );
+    const result = await WebBrowser.openBrowserAsync('https://expo.io', args);
     setTimeout(() => Alert.alert('Result', JSON.stringify(result, null, 2)), 1000);
   };
 

diff --git a/packages/expo-web-browser/ios/EXWebBrowser/EXWebBrowser.m b/packages/expo-web-browser/ios/EXWebBrowser/EXWebBrowser.m
@@ -103,13 +103,13 @@ - (dispatch_queue_t)methodQueue
 
   if (@available(iOS 11.0, *)) {
     NSString *dismissButtonStyle = [arguments valueForKey:@"dismissButtonStyle"];
-    if ([dismissButtonStyle isEqualToString:@"done"]) {
+    if ([@"done" isEqualToString:dismissButtonStyle]) {
       safariVC.dismissButtonStyle = SFSafariViewControllerDismissButtonStyleDone;
     }
-    else if ([dismissButtonStyle isEqualToString:@"close"]) {
+    else if ([@"close" isEqualToString:dismissButtonStyle]) {
       safariVC.dismissButtonStyle = SFSafariViewControllerDismissButtonStyleClose;
     }
-    else if ([dismissButtonStyle isEqualToString:@"cancel"]) {
+    else if (["cancel" isEqualToString:dismissButtonStyle@]) {
       safariVC.dismissButtonStyle = SFSafariViewControllerDismissButtonStyleCancel;
     }
   }