Skip to content

Commit

Permalink
[bare-expo][ios] remove xcode 15 workarounds (#25599)
Browse files Browse the repository at this point in the history
# Why

as mentioned earlier, we should not commit the workarounds to git and make it compatible with xcode 14.

# How

- remove `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` workaround since now we have newer boost library
- remove `-ld_classic` to be compatible with xcode 14
  • Loading branch information
Kudo committed Nov 27, 2023
1 parent 0796ec8 commit c48e52b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 28 deletions.
19 changes: 0 additions & 19 deletions apps/bare-expo/ios/BareExpo.xcodeproj/project.pbxproj

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 0 additions & 9 deletions ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -95,17 +95,8 @@ abstract_target 'Expo Go' do
end
end

# Xcode 15 build error workaround. Remove after updating RN
target_installation_result.native_target.build_configurations.each do |config|
# unary_function and binary_function are no longer provided in C++17 and newer standard modes as part of Xcode 15. They can be re-enabled with setting _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION
# Ref: https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Deprecations
config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)']
config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] << '"_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION" '
end

target_installation_result.native_target.build_configurations.each do |config|
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '13.4'

end

if pod_name == 'Branch'
Expand Down

0 comments on commit c48e52b

Please sign in to comment.