Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(prebuild-config): add fallback image on ios to prevent submissio…
…n failure (#27774) # Why If no `icon` is defined, such as in expo/examples, then the iOS build submission will fail with: ``` [altool] 2024-03-19 18:22:24.315 *** Error: Asset validation failed Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '120x120' pixels, in .png format for iOS versions >= 10.0. To support older versions of iOS, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_interface (ID: b326a4c5-3bf5-4d80-95e4-e7fb608e285f) (90022) ``` Ref: https://expo.dev/accounts/bacon/projects/mar19-test/submissions/830d9df0-224f-47b6-a187-ac8d10d8815c <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How This PR mitigates the chance of failure by creating a full white icon of 1024x1024 when no icon is defined. <!-- How did you build this feature or fix this bug and why? --> # Test Plan Copied the resulting image in an app, built and submitted: - Build details: https://expo.dev/accounts/bacon/projects/mar19-test/builds/badd6130-c8c9-4286-a705-3c419b81eb79 - Submission details: https://expo.dev/accounts/bacon/projects/mar19-test/submissions/c0fd6104-db9f-481f-98e5-541015ed6b12 <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
- Loading branch information