Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Video doesn't adapt to bandwidth if Implementation is ExoPlayer #2177

Closed
normenster opened this issue Sep 6, 2018 · 7 comments
Closed
Labels

Comments

@normenster
Copy link

normenster commented Sep 6, 2018

Expokit Project
"react-native": "https://github.com/expo/react-native/archive/sdk-28.0.0.tar.gz",
"detach": {
"scheme": "expf36d8dd71a764167b8c72128a78cce63",
"iosExpoViewUrl": "https://s3.amazonaws.com/exp-exponent-view-code/ios-v2.6.8-sdk28.0.0-d3178d29-6e12-458b-bfeb-8b7538943b48.tar.gz",
"androidExpoViewUrl": "https://s3.amazonaws.com/exp-exponent-view-code/android-v2.6.4-sdk28.0.0-9ba3198a-7d95-4769-9e16-178a37a70cae.tar.gz"
},

I'm playing a HLS File (.m3u8) Everything works fine on iOS. On Android, bandwitch swichting doesn't happen, the video remains on the lowest quality. When changing androidImplementation to 'MediaPlayer', bandwitch switching works. Any Ideas? Is it maybe fixed in SDK 29 ?

@normenster normenster changed the title Android: Video doesn`t adapt to bandwidth if Implementation is ExoPlayer Android: Video doesn't adapt to bandwidth if Implementation is ExoPlayer Sep 6, 2018
@ide ide added the Android label Sep 6, 2018
@ide
Copy link
Member

ide commented Sep 6, 2018

I don't think this was changed in SDK 29 (you can read the release notes to learn the significant things that changed).

@normenster
Copy link
Author

Yes - but can you confirm that this bandwithMeter thing isn`t implemented? Or should it work?

@normenster
Copy link
Author

@ide Any news on this one? I just want to know, if a m3u8 Manifest in Android Exoplayer Implementation should be adaptive to the clients bitrate, as it is on iOS and also in Android MediaPlayer Implementation.

@DracoBlue
Copy link
Contributor

Any updates on this matter?

@marcusstenbeck
Copy link

marcusstenbeck commented May 15, 2019

I'm running into this issue as well, and setting androidImplementation: "MediaPlayer" makes the adaptive switching work, but also causes a janky and buggy experience. I'm no Java developer, but I looked into what might be the issue, and I see that the data source isn't receiving the bandwidth meter (or I can't figure out how that happens). Could that be the issue?

I'm not Java savvy enough to get this up and running myself, but maybe someone who know their way around can test it out?

https://github.com/expo/expo/blob/master/packages/expo-av/android/src/main/java/expo/modules/av/player/SimpleExoPlayerData.java#L85

Relevant blog post: https://medium.com/google-exoplayer/https-medium-com-google-exoplayer-simplified-bandwidth-meter-usage-17d8189f978b

@watchinharrison
Copy link

watchinharrison commented May 14, 2020

I was also experiencing this issue and took @marcusstenbeck's advice to look into the above and have opened a PR with the fixes #8363

@tsapeta
Copy link
Member

tsapeta commented Jul 16, 2020

Looks like this issue has been solved by #8380 so closing it 😉

@tsapeta tsapeta closed this as completed Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants