Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some failing SDK tests #15999

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Fix some failing SDK tests #15999

merged 2 commits into from
Jan 21, 2022

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Jan 21, 2022

Why

Some tests are failing because of

How

Fixed expo-camera, expo-barcode-scanner and expo-web-browser, but the WebBrowser also requires #15998 .
Updated QRCodeScanner in home app to use enums from expo-camera (and fix yarn tsc).

Test Plan

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 21, 2022
@tsapeta tsapeta marked this pull request as ready for review January 21, 2022 17:11
@tsapeta tsapeta requested a review from Simek January 21, 2022 17:11
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider (it's optional) adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against a7731e6

@Simek
Copy link
Collaborator

Simek commented Jan 21, 2022

I have fixed the Camera tests in:

I'm not sure which approach is better, feel free to close my PR if you prefer the approach from this one. Sorry about that! 😅

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for taking care of that! 👍

@ajsmth
Copy link
Contributor

ajsmth commented Jan 21, 2022

didn't see this PR! thank you!

@ajsmth ajsmth merged commit 6a4cc11 into master Jan 21, 2022
@ajsmth ajsmth deleted the @tsapeta/fix-sdk-tests branch January 21, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: suggestions ExpoBot has some suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants