Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Disable color in tests #16102

Merged
merged 2 commits into from Jan 28, 2022
Merged

[cli] Disable color in tests #16102

merged 2 commits into from Jan 28, 2022

Conversation

EvanBacon
Copy link
Contributor

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jan 27, 2022
@ide
Copy link
Member

ide commented Jan 27, 2022

May instead want to add a setup script (not global setup script) that runs before each test file and sets this if we want it to be the default.

@kbrandwijk
Copy link
Member

May instead want to add a setup script (not global setup script) that runs before each test file and sets this if we want it to be the default.

I think just switching from '1' to '0' in order to have cleaner expects is a good first iteration for the scope of this PR at least.

@EvanBacon EvanBacon merged commit 355cd72 into main Jan 28, 2022
@EvanBacon EvanBacon deleted the @evanbacon/cli/disable-all-color-in-tests branch January 28, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbrandwijk kbrandwijk kbrandwijk approved these changes

@ide ide Awaiting requested review from ide ide is a code owner

@tsapeta tsapeta Awaiting requested review from tsapeta tsapeta is a code owner

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EvanBacon @ide @kbrandwijk @expo-bot