New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jest-expo): update @jest/create-cache-key-function
to match upstream
#17240
Conversation
@jest/create-cache-key-function
to match upstream
I think that all Jest related dependencies should be updated at the same time, so we can avoid any issues and compatibility problems. In case of package you want to update, I think that will need to update at least However, updating |
This PR is orthogonal to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thank for the clarification! 👍
If updated package also support 26 by design, this should be safe to ship.
Yep 🙂 |
Thanks so much, both of you!! I'm always very happy to see |
this was not included in v45, any particular reason? 🙂 |
@SimenB - this was merged before the branch cutoff and it looks like we just missed cherrypicking it to our sdk-45 branch. i'll do this and republish today |
released jest-expo@45.0.1 |
Thanks! |
Updating a project to SDK 45. Just wanted to call out that it seems the transitive dependency stayed on babel-jest v26 despite the callouts here. |
@shamilovtim - using jest-expo@45.0.1? |
Babel-jest is separate: expo/packages/jest-expo/package.json Line 36 in 6e655bd
(Should probably be a peer dep like FWIW we use yarn resolutions at work |
Why
Matches upstream: https://github.com/facebook/react-native/blob/0c4c6ca319fa9dfb23d047e0c7d2a81281d1d8a3/package.json#L96
See facebook/react-native#30637
semi-related, thoughts on updating
babel-jest
to v27 (or even the fresh v28)?How
GH Editor
Test Plan
CI?
Checklist
expo build
(eg: updated@expo/xdl
).expo prebuild
& EAS Build (eg: updated a module plugin).