[templates] fix out of sync template from react-native 0.68 #17266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
approved these changes
Apr 28, 2022
Kudo
deleted the
@kudo/sdk45/__apply_Xcode_12_5_M1_post_install_workaround
branch
brentvatne
pushed a commit
that referenced
this pull request
Apr 28, 2022
…#17266) # Why `__apply_Xcode_12_5_M1_post_install_workaround` was missing when i did #15914. that may introduced some build issue on m1 machine when flipper is enabled. # How - add missing `__apply_Xcode_12_5_M1_post_install_workaround` as from [react-native 0.68 template](https://github.com/facebook/react-native/blob/b5f1b26a8ff4014e45bbb95c5956ba2c2cf286db/template/ios/Podfile#L35) - also update `use_flipper!()` statement as from [react-native 0.68 template](https://github.com/facebook/react-native/blob/b5f1b26a8ff4014e45bbb95c5956ba2c2cf286db/template/ios/Podfile#L31). i think the old flipper issue should be already resolved. # Test Plan tested on m1 macos ```sh $ EXPO_BETA=1 expo init sdk45 # select bare # update ios/Podfile with the change and uncomment use_flipper!() $ expo run:ios # test with flipper ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
__apply_Xcode_12_5_M1_post_install_workaroundwas missing when i did #15914. that may introduced some build issue on m1 machine when flipper is enabled.How
__apply_Xcode_12_5_M1_post_install_workaroundas from react-native 0.68 templateuse_flipper!()statement as from react-native 0.68 template. i think the old flipper issue should be already resolved.Test Plan
tested on m1 macos
Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).