Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][Expo config] Fix Constants.manifest reference and update verbiage #19423

Merged

Conversation

amandeepmittal
Copy link
Member

@amandeepmittal amandeepmittal commented Oct 5, 2022

Why

Refs ENG-6588

How

  • By updating the reference of Constants.manifest to Constants.expoConfig.
  • Also, added a note for SDK 45 and below to use Constants.manifest.
  • updated the overall verbiage, did some re-organization of text and added Callout components for blockquotes.
  • Update link text in https://docs.expo.dev/versions/latest/config/app/ referring back to the Configuration with app.json / app.config.js page. Also, backported to SDK 45, 44, & 43.

Test Plan

Run docs locally via yarn dev and then go open http://localhost:3002/workflow/configuration/.

Checklist

@linear
Copy link

linear bot commented Oct 5, 2022

ENG-6588 Update example in /workflow/configuration

Link: https://docs.expo.dev/workflow/configuration/#dynamic-configuration-with-appconfigjs

The example Constants.manifest.extra.fact === 'kittens are cool'; is outdated. Should be using expoConfig and mention a note about SDK 45 or below.

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Oct 5, 2022
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank for the updates!

@amandeepmittal amandeepmittal merged commit 64341a7 into main Oct 7, 2022
@amandeepmittal amandeepmittal deleted the aman/eng-6588-update-example-in-workflowconfiguration branch October 7, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants