Fix react-native nightly test #19805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: suggestions
Kudo
force-pushed
the
@kudo/react-native-nightly
branch
2 times, most recently
from
ddc96fe
to
9c7b5fc
Compare
- use REACT_NATIVE_OVERRIDE_VERSION rather than rewriting version in package.json - support nightly artifacts on mavenCentral
Kudo
force-pushed
the
@kudo/react-native-nightly
branch
from
9c7b5fc
to
293377c
Compare
Kudo
requested review from
ide,
lukmccall,
wkozyra95,
douglowder and
barthap
as code owners
tsapeta
approved these changes
Nov 3, 2022
Kudo
added a commit
that referenced
this pull request
Dec 21, 2022
Fix broken react-native nightly test - meta ships nightly build binaries on maven central now, we could just use the binaries than building from source. the ci job time reduces dramatically. previously it takes almost four hours, now it takes 51m for android and 60m for ios. - use env `REACT_NATIVE_OVERRIDE_VERSION` to override the version rather than hardcoded 9999.9999.9999 in packages. - expo-modules-core / expo-av / expo-gl - support to download snapshot react-native from maven central - fix some breaking changes from react-native nightly - expo-dev-launcher: `RCTAsyncLocalStorage` is removed - expo-modules-core: remove deprecated `<hermes/hermes.h>` import - expo-modules-core: `RCTAppSetupDefaultRootView` has new parameter - expo: `com.facebook.react.uimanager.UIImplementationProvider` is removed - bare-expo `reactNativeNightly` gradle property is unused now, just rename to `buildReactNativeFromSource` if someone want to use. - [tools] update SetupReactNativeNightly - test suite nightly ci passed - original test suite ci passed to make sure compatibility with sdk 47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fix broken react-native nightly test
How
REACT_NATIVE_OVERRIDE_VERSIONto override the version rather than hardcoded 9999.9999.9999 in packages.RCTAsyncLocalStorageis removed<hermes/hermes.h>importRCTAppSetupDefaultRootViewhas new parametercom.facebook.react.uimanager.UIImplementationProvideris removedreactNativeNightlygradle property is unused now, just rename tobuildReactNativeFromSourceif someone want to use.Test Plan
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).