Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
react-native-v8 app will crash on sdk 47 app
How
the
NativeModules
is a host object, and in react-native-v8, there are some internal data structures for a host object. after monkey patching theNativeModules
, it is now a proxy object. from theReflect.get(target, prop, receiver)
call, it will use host object getter but pass the proxy object (not the original host object). the crash happens at the react-native-v8 code herewe don't return something else from the proxied interceptor; using
target[prop]
is enough.Test Plan
create a v8 app and patch node_modules/expo/build/proxies/NativeModules.js
Checklist
expo prebuild
& EAS Build (eg: updated a module plugin).