Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update expo router babel docs in setup for SDK 50 #24832

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

EvanBacon
Copy link
Contributor

Why

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Oct 11, 2023
Copy link
Member

@amandeepmittal amandeepmittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of small suggestions and I'm approving this now as it looks good to me but feel free to merge what you want.

docs/pages/router/reference/troubleshooting.mdx Outdated Show resolved Hide resolved
docs/pages/routing/installation.mdx Outdated Show resolved Hide resolved
@amandeepmittal amandeepmittal changed the title Update expo router babel docs in setup for SDK 50 [docs] Update expo router babel docs in setup for SDK 50 Oct 14, 2023
@EvanBacon EvanBacon merged commit 3c9827e into main Dec 11, 2023
5 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/router/babel-docs branch December 11, 2023 22:39
onizam95 pushed a commit to onizam95/expo-av-drm that referenced this pull request Jan 15, 2024
# Why

- Companion PR to expo#24779 but we'll keep
it in draft until we get closer to releasing SDK 50.

---------

Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants