fix(babel): fix unused platform code removal #25171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
approved these changes
Nov 1, 2023
ide
approved these changes
Nov 2, 2023
packages/babel-preset-expo/src/__tests__/platform-shaking.test.ts
Outdated
Show resolved
Hide resolved
ide
approved these changes
Nov 2, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
EvanBacon
added a commit
that referenced
this pull request
Nov 6, 2023
# Why Tests were technically failing, this fixes them. Related #25171
ide
reviewed
Nov 8, 2023
| @@ -98,6 +98,21 @@ function babelPresetExpo(api: ConfigAPI, options: BabelPresetExpoOptions = {}): | |||
| extraPlugins.push(require('@babel/plugin-transform-parameters')); | |||
| } | |||
|
|
|||
| if (!isDev && hasModule('metro-transform-plugins')) { | |||
There was a problem hiding this comment.
Why should this not run in development, too?
There was a problem hiding this comment.
We don't do any minification in development to keep things fast, might change in the future but right now it doesn't provide much benefit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Metro applies this plugin too but it does it after the imports have been transformed which breaks the plugin. Here, we'll apply it before the commonjs transform, in production, to ensure
Platform.OSis replaced with a string literal and__DEV__is converted to a boolean.Applying early also means that web can be transformed before the
react-native-webtransform mutates the import.Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).