Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(babel): support all options in top-level object #25172

Merged
merged 2 commits into from Nov 1, 2023

Conversation

EvanBacon
Copy link
Contributor

Why

Based on feedback from @gaearon, we now normalize the babel options so you can use any value in the top-level object, and provide platform-specific overrides in the sub-objects web and native.

This PR also adds better documentation for the available options.

Test Plan

Tests will continue to pass.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Nov 1, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@gaearon
Copy link
Contributor

gaearon commented Nov 1, 2023

nice, thanks

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Nov 1, 2023
@EvanBacon EvanBacon merged commit 22c3cf2 into main Nov 1, 2023
8 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/babel/improve-options branch November 1, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants