[2/n] upgrade react-native 0.73 #25488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
force-pushed
the
@gabrieldonadel/upgrade-react-native-0-73-part-2
branch
from
3dee83b
to
388e06a
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/upgrade-react-native-0-73-part-3
branch
2 times, most recently
from
6d60e2c
to
4d3544f
Compare
gabrieldonadel
changed the title
gabrieldonadel
force-pushed
the
@gabrieldonadel/upgrade-react-native-0-73-part-3
branch
from
4d3544f
to
77cef72
Compare
|
I'm inverting the order between this PR and #25453 to fix our CI |
gabrieldonadel
changed the base branch from
@gabrieldonadel/upgrade-react-native-0-73-part-2
to
main
gabrieldonadel
force-pushed
the
@gabrieldonadel/upgrade-react-native-0-73-part-3
branch
from
639b6fc
to
347f9e0
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/upgrade-react-native-0-73-part-3
branch
from
347f9e0
to
f4d5773
Compare
gabrieldonadel
requested review from
tsapeta,
brentvatne,
Kudo,
ide,
lukmccall,
douglowder,
EvanBacon and
byCedric
as code owners
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
douglowder
approved these changes
Nov 21, 2023
Kudo
approved these changes
Nov 21, 2023
|
Android Instrumentation Tests is failing due to unrelated changes, going to merge as is |
gabrieldonadel
deleted the
@gabrieldonadel/upgrade-react-native-0-73-part-3
branch
3 tasks
gabrieldonadel
added a commit
that referenced
this pull request
Nov 29, 2023
# Why Follow up #25488 for react-native 0.73 upgrade close ENG-9739 # How - update package versions - `react-native 0.73.0-rc.5 -> 0.73.0-rc.6` - Publish dev home - upgrade project templates based on [upgrade-helper](https://react-native-community.github.io/upgrade-helper/?from=0.73.0-rc.5&to=0.73.0-rc.6) # Test Plan - bare-expo ios / android - Expo Go - fabric ios / android - ci passed # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [X] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why Follow up expo#25453 for react-native 0.73 upgrade close ENG-9739 # How - update package versions - `react-native 0.73.0-rc.4 -> 0.73.0-rc.5` - Bump test-suite iOS build timeout to 45 min - Publish dev home - Remove @react-native/dev-middleware patch # Test Plan - bare-expo ios / android - Expo Go - fabric ios / android - ci passed # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why Follow up expo#25488 for react-native 0.73 upgrade close ENG-9739 # How - update package versions - `react-native 0.73.0-rc.5 -> 0.73.0-rc.6` - Publish dev home - upgrade project templates based on [upgrade-helper](https://react-native-community.github.io/upgrade-helper/?from=0.73.0-rc.5&to=0.73.0-rc.6) # Test Plan - bare-expo ios / android - Expo Go - fabric ios / android - ci passed # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [X] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Follow up #25453 for react-native 0.73 upgrade
close ENG-9739
How
react-native 0.73.0-rc.4 -> 0.73.0-rc.5Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).