Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] update stripe-react-native to 0.35.0 #25499

Merged
merged 7 commits into from
Nov 22, 2023
Merged

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Nov 21, 2023

Why

update vendoring modules for sdk 50
close ENG-10669

How

  • et uvm -m @stripe/stripe-react-native -c 'v0.35.0'
  • backport native stripe version to old sdks' podspec and build.gradle
  • transform manually
    • [android] remove GooglePayButtonManager.kt, GooglePayButtonView.kt
    • [android] remove GooglePayButtonManager() and AddToWalletButtonManager() in StripeSdkPackage.kt
    • [android] revert import com.stripe.android.R change in CardFormView.kt
    • [android] backport some enum cases to fix build errors on sdk 49
    • [android] revert glide listener changes in AddToWalletButtonView.kt
    • [ios] remove stripe-react-native/ios/Tests/**/* test files
    • [ios] rename pushprovisioning to PushProvisioning in file names. (only needed in this sdk upgrade)

Test Plan

  1. clone and setup stripe example app

  2. in example/

  3. install unversioned expo go to simulator/emulator

  4. modify the stripe cloned repo's maestro e2e test cases

    • cd e2e-tests
    • modify the *.yml file you want to test and replace - launchApp to
    - stopApp
    - openLink: exp://127.0.0.1:8081
    • replace the 127.0.0.1:8081 to the local dev-server address
  5. run maestro test, e.g. maestro --device {device_id} test -e APP_ID=host.exp.Exponent cardfield-basic.yml

  6. i only went through these test cases

    • cardfield-basic.yml
    • paymentsheet-basic.yml
    • paymentsheet-customFlow.yml

Checklist

Copy link

linear bot commented Nov 21, 2023

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Nov 21, 2023
@Kudo Kudo changed the title [go] update stripe-react-native to 0.50.0 [go] update stripe-react-native to 0.35.0 Nov 21, 2023
@Kudo Kudo marked this pull request as ready for review November 22, 2023 14:56
@Kudo Kudo requested review from alanjhughes and removed request for brentvatne and ide November 22, 2023 14:56
@Kudo Kudo merged commit cdae7f2 into main Nov 22, 2023
17 checks passed
@Kudo Kudo deleted the @kudo/sdk50/vendor-stripe branch November 22, 2023 16:56
onizam95 pushed a commit to onizam95/expo-av-drm that referenced this pull request Jan 15, 2024
# Why

update vendoring modules for sdk 50
close ENG-10669

# How

- `et uvm -m @stripe/stripe-react-native -c 'v0.35.0'`
- backport native stripe version to old sdks' podspec and build.gradle
- transform manually
  - [android] remove `GooglePayButtonManager.kt`, `GooglePayButtonView.kt`
  - [android] remove `GooglePayButtonManager()` and `AddToWalletButtonManager()` in `StripeSdkPackage.kt`
  - [android] revert `import com.stripe.android.R` change in `CardFormView.kt`
  - [android] backport some enum cases to fix build errors on sdk 49
  - [android] revert glide listener changes in `AddToWalletButtonView.kt`
  - [ios] remove `stripe-react-native/ios/Tests/**/*` test files
  - [ios] rename `pushprovisioning` to `PushProvisioning` in file names. (only needed in this sdk upgrade)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants