Move expo-doctor over from expo-cli #25503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-kurak
requested review from
byCedric
and removed request for
alanjhughes
byCedric
reviewed
Nov 22, 2023
byCedric
reviewed
Nov 22, 2023
There was a problem hiding this comment.
This is just a suggestion we could do, see #25424 (comment) for more info.
Co-authored-by: Cedric van Putten <me@bycedric.com>
Co-authored-by: Cedric van Putten <me@bycedric.com>
byCedric
approved these changes
Nov 29, 2023
Co-authored-by: Cedric van Putten <me@bycedric.com>
Co-authored-by: Cedric van Putten <me@bycedric.com>
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why Add expo-doctor to this repository for future maintenance # How - Copied over expo-doctor folder from expo-cli/packages - Adapted changes from expo#25422 to switch scripts to `expo-module` equivalents - updated unit tests to properly mock `spawnAsync` - Fixed linter warnings # Questions - I'm not sure what, if anything needs to be added to CI jobs, since Doctor only has unit tests currently - Kind of guessing as to what **tsconfig.json** should look like, mostly copied @expo/cli with a few added package-specific flags # Test Plan - [x] Test locally - [ ] see if CI passes --------- Co-authored-by: Cedric van Putten <me@bycedric.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Add expo-doctor to this repository for future maintenance
How
@expo/babel-preset-cliwithexpo-module-scripts#25422 to switch scripts toexpo-moduleequivalentsspawnAsyncQuestions
Test Plan