New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli, router, babel): add router root to metro cache #25658
Merged
EvanBacon
merged 8 commits into
main
from
@evanbacon/cli/add-router-root-to-metro-cache
Nov 30, 2023
Merged
feat(cli, router, babel): add router root to metro cache #25658
EvanBacon
merged 8 commits into
main
from
@evanbacon/cli/add-router-root-to-metro-cache
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
requested review from
Simek,
amandeepmittal,
marklawlor,
brentvatne,
ide and
byCedric
as code owners
November 30, 2023 05:50
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Nov 30, 2023
amandeepmittal
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small suggestions but LGTM!
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
github-actions
bot
added
bot: fingerprint changed
and removed
bot: fingerprint compatible
labels
Nov 30, 2023
Seems like on
when trying to use |
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why - Add support for invalidating the cache when the app directory changes. We use this feature in our E2E tests so it would be good to ensure it works properly. - This change also enables us to move the Expo config read operation out of the babel preset which should generally be safer and faster. - By adding this invalidation we also ensure that the cache is cleared when expo-router is installed, this should help reduce issues related to manual expo-router installation in existing projects. - This change also deletes `expo-router/babel` in favor of `babel-preset-expo` which is properly tested. - I've also added the option to change the root directory to the docs and noted that it's a dangerous operation that may lead to issue closing. # Test Plan - Ensure project continue working. - Ensure the cache clears when the root directory changes. <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
expo-router/babel
in favor ofbabel-preset-expo
which is properly tested.Test Plan
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).