Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prebuild-config] revert systemBackgroundColor #26536

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Jan 19, 2024

Why

fixes #26491
close ENG-11122

How

revert #25971 and add systemBackgroundColor on SplashScreenBackground

Test Plan

test repro on #26491

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jan 19, 2024
@Kudo Kudo force-pushed the @kudo/eng-11122-expo-splash-screen-ios-defined-backgroundcolor-in-appjson-is branch from 6c8531c to 1b97d63 Compare January 20, 2024 10:22
@Kudo Kudo marked this pull request as ready for review January 20, 2024 13:55
@Kudo Kudo requested a review from EvanBacon as a code owner January 20, 2024 13:55
@Kudo Kudo requested a review from brentvatne January 20, 2024 13:55
@Kudo Kudo merged commit 2254329 into main Jan 21, 2024
12 checks passed
@Kudo Kudo deleted the @kudo/eng-11122-expo-splash-screen-ios-defined-backgroundcolor-in-appjson-is branch January 21, 2024 02:42
Kudo added a commit that referenced this pull request Jan 21, 2024
# Why

fixes #26491
close ENG-11122

# How

revert #25971 and add `systemBackgroundColor` on
`SplashScreenBackground`

(cherry picked from commit 2254329)
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[expo-splash-screen] [iOS] Defined backgroundColor in app.json is ignored in both version 0.26.2 and 0.26.3
4 participants