Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): avoid building __typetests__ files #27089

Merged
merged 3 commits into from Mar 28, 2024

Conversation

byCedric
Copy link
Member

Why

During load-time benchmarking of individual files, I noticed we are building __typetests__ into the build directory of the cli. This would then be included in the release itself.

See https://cdn.jsdelivr.net/npm/@expo/cli@0.17.5/build/src/start/server/type-generation/__typetests__/

How

  • Exclude **/__typetests__/** when building with SWC

Test Plan

Minor change, and testable through npm pack. Make sure build does not include the __typetests__ folder.

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Feb 14, 2024
@byCedric byCedric merged commit ec0f971 into main Mar 28, 2024
5 of 6 checks passed
@byCedric byCedric deleted the @bycedric/cli/skip-building-typetests branch March 28, 2024 16:00
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants