(router): add url hash support #27105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
marklawlor
force-pushed
the
marklawlor/router/ENG-6362
branch
from
976d8bf
to
70d0375
Compare
github-actions
bot
added
bot: fingerprint compatible
and removed
bot: fingerprint changed
labels
marklawlor
commented
Feb 29, 2024
| it(`returns the pathname without hash for ${url}`, () => { | ||
| expect(getUrlWithReactNavigationConcessions(url).inputPathnameWithoutHash).toBe(expected); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
These were removed as inputPathnameWithoutHash isn't actually used in the code base and we not support hashes
marklawlor
requested review from
Simek,
amandeepmittal and
EvanBacon
as code owners
expo-bot
added
bot: passed checks
marklawlor
force-pushed
the
marklawlor/router/ENG-6362
branch
2 times, most recently
from
7134b17
to
a384a1f
Compare
EvanBacon
reviewed
Mar 4, 2024
|
|
||
| The URL (hash)[https://developer.mozilla.org/en-US/docs/Web/API/URL/hash] is a string that follows the `#` symbol in a URL. It is commonly used on websites to link to a specific section of a page, but it can also be used to store data. Expo Router treats the hash as a special search parameter using the name `#`. It can be accessed and modified using the same hooks and APIs from [search parameters](/router/reference/search-parameters/). | ||
|
|
||
| ```tsx app/hash.tsx |
There was a problem hiding this comment.
Suggested change
| ```tsx app/hash.tsx | |
| ```tsx app/index.tsx |
|
Comment out docs so they are not deployed |
EvanBacon
approved these changes
Mar 4, 2024
marklawlor
force-pushed
the
marklawlor/router/ENG-6362
branch
from
a384a1f
to
7fe7e6a
Compare
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
marklawlor
force-pushed
the
marklawlor/router/ENG-6362
branch
from
6393907
to
0f27456
Compare
3 tasks
amandeepmittal
added a commit
that referenced
this pull request
Mar 14, 2024
# Why <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> Follow-up #27105 # How <!-- How did you build this feature or fix this bug and why? --> After confirming with @marklawlor, the "Hash support" section is unversioned for now so we should hide it. # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> Run docs locally and visit: http://localhost:3002/router/reference/search-parameters/ ## Preview  # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Adds URL hash support to Expo Router. This enable 3rd party services that use the hash as part of work flows (e.g authentication)
How
The hash is converted into a search parameter called
#. This was chosen as its not a valid search parameter and the encoded version is unlikely to be in use.Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).