Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlite] Support import expo-sqlite/next from ESM project #27423

Merged
merged 2 commits into from Mar 5, 2024
Merged

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Mar 4, 2024

Why

when importing expo-sqlite/next from an ESM project, it cannot resolve the import.

How

add exports to support ./next

Test Plan

tested the import from an ESM project

Checklist


Co-authored-by: Johannes Schickling schickling.j@gmail.com

Co-authored-by: Johannes Schickling <schickling.j@gmail.com>
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 4, 2024
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 4, 2024
@Kudo Kudo marked this pull request as ready for review March 4, 2024 15:30
@Kudo Kudo requested a review from alanjhughes as a code owner March 4, 2024 15:30
@Kudo Kudo merged commit ddec9c0 into main Mar 5, 2024
8 checks passed
@Kudo Kudo deleted the @kudo/sqlite-esm branch March 5, 2024 03:08
Kudo added a commit that referenced this pull request Mar 5, 2024
# Why

when importing `expo-sqlite/next` from an ESM project, it cannot resolve
the import.

# How

add `exports` to support `./next`

---------

Co-authored-by: Johannes Schickling <schickling.j@gmail.com>
(cherry picked from commit ddec9c0)
@Kudo Kudo added the published Changes from the PR have been published to npm label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants