[router]: refactor matchArrayGroupName to be similar to matchGroupName #27459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: suggestions
marklawlor
force-pushed
the
marklawlor/router/matchArrayGroupName
branch
from
51d2561
to
aa9ad5e
Compare
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
marklawlor
force-pushed
the
marklawlor/router/matchArrayGroupName
branch
from
aa9ad5e
to
1049db4
Compare
EvanBacon
reviewed
Mar 6, 2024
| @@ -68,3 +70,41 @@ describe(getNameFromFilePath, () => { | |||
| ); | |||
| }); | |||
| }); | |||
|
|
|||
| describe(matchArrayGroupName, () => { | |||
| it(`matches`, () => { | |||
EvanBacon
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
matchArrayGroupNameis similar tomatchGroupNamebut its regex was implemented differently and it returned all groups, not just the first oneThis PR keeps the functionality & regex of
matchArrayGroupNameto be similar tomatchGroupName.This addresses some bugs with
matchArrayGroupNamewhere it incorrectly handled((foo),(bar))How
Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).