Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router,server,cli): add support for array syntax with server exports #27462

Merged
merged 7 commits into from Mar 7, 2024

Conversation

EvanBacon
Copy link
Contributor

Why

How

  • add support for API routes to match array syntax variations.
  • add support for exporting each unique nested variation of HTML routes for server hosting.

Test Plan

  • Added extensive tests for the new logic in the server manifest creation, html collection, and e2e server requesting.
  • I've also updated the CLI collection tests to use the same manifest mock creation as the integration navigation tests.

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 6, 2024
EvanBacon and others added 3 commits March 5, 2024 21:01
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@EvanBacon EvanBacon marked this pull request as ready for review March 6, 2024 03:02
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 6, 2024
@EvanBacon EvanBacon merged commit 3d2157c into main Mar 7, 2024
11 of 12 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/server/fix-array-serving branch March 7, 2024 19:25
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web export with server output results in 404s for routes in tabs with shared array syntax
3 participants