[cli] Filter extra avd info when listing emulators #27497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #27473 |
byCedric
requested changes
Mar 8, 2024
expo-bot
added
bot: passed checks
byCedric
approved these changes
Mar 8, 2024
gabrieldonadel
added a commit
that referenced
this pull request
Mar 13, 2024
Recently got a few reports from @brentvatne and @Simek regarding a non bootable device being listed in Orbit <details> <summary>Check image</summary>  </details> After doing some testing this same bug also applies to expo-cli ``` yarn expo run:android yarn run v1.22.21 $ /Users/brent/code/microfoam/node_modules/.bin/expo run:android ✔ Created native directory ✔ Updated package.json | no changes ✔ Finished prebuild › Opening emulator INFO | Storing crashdata in: /tmp/android-brent/emu-crash-34.1.18.db, detection is enabled for process: 92192 Error: The emulator (INFO | Storing crashdata in: /tmp/android-brent/emu-crash-34.1.18.db, detection is enabled for process: 92192) quit before it finished opening. You can try starting the emulator manually from the terminal with: /Users/brent/Library/Android/sdk/emulator/emulator @INFO | Storing crashdata in: /tmp/android-brent/emu-crash-34.1.18.db, detection is enabled for process: 92192 Error: The emulator (INFO | Storing crashdata in: /tmp/android-brent/emu-crash-34.1.18.db, detection is enabled for process: 92192) quit before it finished opening. You can try starting the emulator manually from the terminal with: /Users/brent/Library/Android/sdk/emulator/emulator @INFO | Storing crashdata in: /tmp/android-brent/emu-crash-34.1.18.db, detection is enabled for process: 92192 at stopWaitingAndReject (/Users/brent/code/microfoam/node_modules/@expo/cli/build/src/start/platforms/android/emulator.js:110:20) at ChildProcess.<anonymous> (/Users/brent/code/microfoam/node_modules/@expo/cli/build/src/start/platforms/android/emulator.js:121:13) at ChildProcess.emit (node:events:517:28) at ChildProcess._handle.onexit (node:internal/child_process:292:12) error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ``` AVD IDs cannot contain spaces, so in order to remove all the extra info returned by `emulator -list-avds`, we can just filter out lines that contain spaces Running `yarn expo run:android -d` should not list ` INFO | Storing crashdata in: /tmp/android-brent/emu-crash-34.1.18.db, detection is enabled for process: 92342 (emulator)` as an option to launch <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Recently got a few reports from @brentvatne and @Simek regarding a non bootable device being listed in Orbit
Check image
After doing some testing this same bug also applies to expo-cli
How
AVD IDs cannot contain spaces, so in order to remove all the extra info returned by
emulator -list-avds, we can just filter out lines that contain spacesTest Plan
Running
yarn expo run:android -dshould not listINFO | Storing crashdata in: /tmp/android-brent/emu-crash-34.1.18.db, detection is enabled for process: 92342 (emulator)as an option to launchChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).