Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use typeof window checks for removing server code #27514

Merged
merged 4 commits into from Mar 8, 2024
Merged

chore: use typeof window checks for removing server code #27514

merged 4 commits into from Mar 8, 2024

Conversation

EvanBacon
Copy link
Contributor

Why

  • It's common in the web frameworks world to minify typeof window checks. We'll add this to our babel config in a follow up PR.

How

  • This PR migrates typeof document checks to typeof window so we can tree shake extra code.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 8, 2024
EvanBacon and others added 2 commits March 7, 2024 21:32
@EvanBacon @expo-bot
Apply suggestions from code review
2f33136 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@EvanBacon @expo-bot
Update packages/expo/CHANGELOG.md
e26f0bf 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 8, 2024
@EvanBacon EvanBacon merged commit 186bf0f into main Mar 8, 2024
10 of 11 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/web/use-typeof-window-checks branch March 8, 2024 19:16
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsapeta tsapeta tsapeta approved these changes

@ide ide Awaiting requested review from ide ide is a code owner

@brentvatne brentvatne Awaiting requested review from brentvatne brentvatne is a code owner

@lukmccall lukmccall Awaiting requested review from lukmccall lukmccall is a code owner

@aleqsio aleqsio Awaiting requested review from aleqsio aleqsio is a code owner

@byCedric byCedric Awaiting requested review from byCedric byCedric is a code owner

@marklawlor marklawlor Awaiting requested review from marklawlor marklawlor is a code owner

Assignees
No one assigned
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EvanBacon @tsapeta @brentvatne @expo-bot